Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(packages): publish packages #144

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

DuCanhGH
Copy link
Owner

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@ducanh2912/next-pwa@10.2.4

Patch Changes

  • 07c8861 Thanks @DuCanhGH! - fix(core): fixed invalid precache manifest with assetPrefix

    • Turns out it is much more complex than we thought. To make this work with assetPrefix, distDir, and basePath, we now remove ${publicPath}${publicDirRelativeToOutputPath} from public files in manifestTransforms because assetPrefix is not intended for files that are in the public directory and we also want to remove /_next/${publicDirRelativeToOutputPath} from the URL, since that is not how we resolve files in the public directory.

@DuCanhGH DuCanhGH merged commit db2e02c into master Jan 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant