Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next-pwa): fixed __PWA_SW_ENTRY_WORKER__ being undefined #34

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

DuCanhGH
Copy link
Owner

@DuCanhGH DuCanhGH commented Jun 16, 2023

This happens when cacheOnFrontEndNav is not enabled, which causes webpack.DefinePlugin to not be called.

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2023

🦋 Changeset detected

Latest commit: 58f6b78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@ducanh2912/next-pwa Patch
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DuCanhGH DuCanhGH merged commit 9850306 into master Jun 16, 2023
2 checks passed
@DuCanhGH DuCanhGH mentioned this pull request Jun 16, 2023
@DuCanhGH DuCanhGH deleted the fix-sw-entry-undefined branch June 16, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant