Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial fixes #25

Open
wants to merge 3 commits into
base: refactor
Choose a base branch
from
Open

Initial fixes #25

wants to merge 3 commits into from

Conversation

MaxCan-Code
Copy link

@MaxCan-Code
Copy link
Author

@rodrigogiraoserrao @rikedyp @xpqz can you review it? Thanks

@rodrigogiraoserrao
Copy link
Contributor

At this point, I'm so removed from this project that I don't feel confident reviewing your PR.

Copy link

@xpqz xpqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rikedyp
Copy link
Contributor

rikedyp commented Jan 18, 2025

These changes are attached to Rodrigo's refactoring which was never completed and means significant changes to the codebase, including the use of Poetry to manage dependencies. Even if we approve these changes, a user coming to the repository home page isn't going to benefit due to lack of documentation. I'm inclined to cherry pick the script patch into the main branch and then leave the refactoring until somebody is able to better document at least how an end user is supposed to get pynapl working from scratch and better if there were contributing instructions including the use of Poetry, and better yet if the project was made available on pypi as I think was originally intended when the refactoring began.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants