Design Document: Omega-0 algorithm formulation #33
Conversation
|
@mark-petersen, as I mentioned in #32, please keep the checklist when you make new Omega PRs. |
|
This PR is still under development. Early comments are welcome, but I will add reviewers and post again when the algorithm section is complete. |
mark-petersen
force-pushed
the
mark-petersen/omega/design-omega0-sw-algorithms
branch
from
3e3776a
to
27be3fd
Compare
|
@mark-petersen, it doesn't look like you rebased onto the current |
mark-petersen
force-pushed
the
mark-petersen/omega/design-omega0-sw-algorithms
branch
from
27be3fd
to
5286c80
Compare
Move constants from ice_constants_colpkg.F90 to mpas_seaice_constants.F
mark-petersen
force-pushed
the
mark-petersen/omega/design-omega0-sw-algorithms
branch
from
e69b893
to
a670ea0
Compare
mark-petersen
force-pushed
the
mark-petersen/omega/design-omega0-sw-algorithms
branch
from
30ba0c0
to
69a0915
Compare
mark-petersen
force-pushed
the
mark-petersen/omega/design-omega0-sw-algorithms
branch
from
663d824
to
62cec08
Compare
|
During this review, the documentation is available here for convenient viewing. |
mark-petersen
force-pushed
the
mark-petersen/omega/design-omega0-sw-algorithms
branch
from
1bc24ad
to
6aab934
Compare
|
Rebased and squashed. This is document is now done and ready for review. |
|
Please review when you get a chance: @sbrus89 @mwarusz @hyungyukang I would like to make any revisions and merge this week. |
There was a problem hiding this comment.
@mark-petersen, this looks great to me. I just had a couple really minor comments from reading through.
There was a problem hiding this comment.
Looks good @mark-petersen. I also only have minor comments.
There was a problem hiding this comment.
@mark-petersen , changes look great. @sbrus89 and @mwarusz 's reviews covered my suggestions and improved the doc. Many thanks for your work!
There was a problem hiding this comment.
Thanks for addressing those changes, @mark-petersen. This is a really nice resource to have!
mark-petersen
force-pushed
the
mark-petersen/omega/design-omega0-sw-algorithms
branch
from
982f4dd
to
1a888d6
Compare
|
@mwarusz I corrected based on your comments. The full document is here. In particular, I expanded the section on the perpendicular gradient and the section on del2. Please review again if you like, and I can merge in once you've approved. |
|
@mwarusz, thank you for your detailed review. I addressed all of your comments, and the revised document is here. |
|
@mark-petersen this is really nice. I think it is so great to have this all in one place. Thanks for all the work on it |
There was a problem hiding this comment.
@mark-petersen Thanks for addressing all of my previous comments. This looks almost ready, but I do have some new suggestions.
| $$ | ||
| The normalization can be found through simple geometric arguments to be similar to above, | ||
| $$ | ||
| A_v = \sum_{e\in EV(v)} \frac{{\bar A}_{e}}{4}. |
There was a problem hiding this comment.
Shouldn't this simply be {\hat A}_v ? I don't see this expression in MPAS-O code. It just uses areaTriangle.
There was a problem hiding this comment.
Yes. I updated it to {\hat A}_v. I just meant to show here the equivalence of the two sides in area. I updated the words to make that more clear.
|
@mwarusz thanks for your attention to detail, and sorry for the delay. The revised documentation is available here. I added a new figure to show exactly what each area region is to help future readers, below the variable definitions. |
There was a problem hiding this comment.
Thanks @mark-petersen for your hard work on this document. The added figure is very helpful. The only issue I found are two typos where c is used as cell index instead of i, so I think I can safely approve.
mark-petersen
force-pushed
the
mark-petersen/omega/design-omega0-sw-algorithms
branch
from
df80916
to
5b38158
Compare
|
rebased to handle conflicts. |
mark-petersen
deleted the
mark-petersen/omega/design-omega0-sw-algorithms
branch
Add section 3, the algorithm formulation, to the design document. During this review, the documentation is available here for convenient viewing.
Checklist