Skip to content

Commit

Permalink
docs: Remove TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
karatugo committed Sep 17, 2024
1 parent 536fe4f commit f29e168
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
9 changes: 1 addition & 8 deletions sumstats_service/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ def delete_sumstats(callback_id):
return Response(response=resp, status=200, mimetype="application/json")


# TODO: refactor this
@app.route("/v1/sum-stats/<string:callback_id>", methods=["PUT"])
def update_sumstats(callback_id):
content = request.get_json(force=True)
Expand Down Expand Up @@ -227,7 +226,6 @@ def update_sumstats(callback_id):
if move_files_result.successful():
logger.info(f"{callback_id=} :: move_files_result successful")
globus_endpoint_id = move_files_result.get()["globus_endpoint_id"]
# TODO: test by calling update_sumstats
metadata_conversion_result = convert_metadata_to_yaml.apply_async(
args=[resp["studyList"][0]["gcst"], False],
kwargs={"globus_endpoint_id": globus_endpoint_id},
Expand Down Expand Up @@ -409,12 +407,7 @@ def convert_metadata_to_yaml(
config.MONGO_DB,
)

# TODO: test by publishing to rabbitmq directly as in deposition
# ie is_save default value
# TODO: test by publishing to rabbitmq directly as in nightly cron ie is_save false

# save by default.
# TODO: Explicitly set otherwise in nightly cron scripts.
# Explicitly set otherwise in nightly cron scripts.
try:
if is_save:
logger.info("is save true")
Expand Down
2 changes: 1 addition & 1 deletion sumstats_service/resources/mongo_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def __init__(self, uri, username, password, database):
self.study_collection = self.database["sumstats-study-meta"]
self.error_collection = self.database["sumstats-errors"]
self.callback_collection = self.database["sumstats-callback-tracking"]
# TODO: update cron entries and delete this collection
# TODO: This collection can be deleted after yaml gen fix
self.task_failure_collection = self.database["sumstats-celery-task-failures"]
self.metadata_yaml_collection = self.database["sumstats-metadata-yaml"]
self.studies_collection = self.database["studies"]
Expand Down

0 comments on commit f29e168

Please sign in to comment.