Add strang implicit spectral em redo #5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgrote
added
component: spectral
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /** | ||
| * \brief Time-biasing parameter for fields used on RHS to advance system | ||
| */ | ||
| amrex::Real m_theta = 0.5; |
There was a problem hiding this comment.
@dpgrote Is m_theta used?
There was a problem hiding this comment.
I've removed references to theta.
| @@ -83,7 +83,8 @@ public: | |||
| [[nodiscard]] RT dotProduct( const WarpXSolverVec& a_X ) const; | |||
|
|
|||
| void Copy ( warpx::fields::FieldType a_array_type, | |||
| warpx::fields::FieldType a_scalar_type = warpx::fields::FieldType::None ); | |||
| warpx::fields::FieldType a_scalar_type = warpx::fields::FieldType::None, | |||
| bool allow_type_mismatch = false); | |||
There was a problem hiding this comment.
I understand why this flag is needed here. Would be nice to not need it. That would require modifications to the WarpXSolverVec class. Ideally, m_array_type and m_scalar type would just reflect the centering for the FABs. Then, current_fp and efield_fp would be the same type. This should of course be a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements use of the PSATD field advance coupled with the implicit solver, using a Strang split advance.
This requires the input parameter psatd.update_with_rho = 0.
With psatd.periodic_single_box_fft = 1, exact energy conservation is obtained. Otherwise good conservation is seen, but not exact (will depend on parameters).
Convergence is found for wpedt <= 1.9 (compared to wpedt < 0.25 for FDTD).
This PR replaces PR #4662.
A task for a future PR would be to implement specialized source free spectral advance routines (as noted in source comments).