Implicit add filtering #5086
Merged
Implicit add filtering #5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgrote
added
the
component: implicit solvers
Source/Evolve/WarpXEvolve.cpp
Outdated
Comment on lines
572
to
573
| if (use_filter) { ApplyFilterJ(current_fp_vay, lev); } | ||
| if (use_filter) { ApplyFilterMF(current_fp_vay, lev); } | ||
| } |
There was a problem hiding this comment.
Should ApplyFilterJ() be different than applying a filter for E or B when using curvilinear geometries?
I believe the filter should be applied to the current before dividing by the volume element to convert to current density. Perhaps this is being done somewhere else?
There was a problem hiding this comment.
You are probably correct, but filtering doesn't work for RZ as it is now (at least for FDTD). As it is now, the inverse volume scaling is done before the filtering. That order could be changed but that would need to be a separate PR.
|
This looks good to me. We could also add filtering to the magnetic field as an option. That should probably be a separate PR though. |
JustinRayAngus
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds filtering to the implicit solver, replacing PR #4600.
It is a simple change. All that is needed is adding a call to filter the
Efield_fpjust before the particles are pushed. The current density is already filtered inSyncCurrentAndRho.The name of the routine
ApplyFilterJwas changed toApplyFilterMFsince it now has a more general usage.