Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update option name to clean test dirs #5129

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Aug 12, 2024

The option rm_testdir was renamed to clean_testdir in AMReX-Codes/regression_testing#146.

@EZoni EZoni added bug Something isn't working component: tests Tests and CI bug: affects latest release Bug also exists in latest release version labels Aug 12, 2024
@EZoni EZoni requested a review from ax3l August 12, 2024 20:54
@EZoni EZoni force-pushed the EZoni_clean_testdir branch from c6dfac5 to 44fe1f8 Compare August 12, 2024 21:02
@EZoni
Copy link
Member Author

EZoni commented Aug 12, 2024

@ax3l
PR AMReX-Codes/regression_testing#146 on the AMReX regression testing side was just merged and the corresponding branch deleted. Thus the current CI setup where we clone that branch and use the old name of the option will not work anymore. This PR should fix that.

Update: I just restored the branch of AMReX-Codes/regression_testing#146 because this might cause issues given that the previous implementation was included in the latest release. It should be safe to delete my branch once the next release is issued.

@ax3l ax3l self-assigned this Aug 12, 2024
@ax3l ax3l merged commit 502e5ea into ECP-WarpX:development Aug 12, 2024
44 of 47 checks passed
@EZoni EZoni deleted the EZoni_clean_testdir branch August 12, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: tests Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants