-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] CI tests: use ubuntu 24.04 for clang tidy and clang sanitizer tests #5352
Open
lucafedeli88
wants to merge
11
commits into
ECP-WarpX:development
Choose a base branch
from
lucafedeli88:use_ubuntu_24_04_for_clang_tidy_and_sanitizer_checks
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] CI tests: use ubuntu 24.04 for clang tidy and clang sanitizer tests #5352
lucafedeli88
wants to merge
11
commits into
ECP-WarpX:development
from
lucafedeli88:use_ubuntu_24_04_for_clang_tidy_and_sanitizer_checks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucafedeli88
changed the title
CI tests: use ubuntu 24.04 for clang tidy and clang sanitizer tests
[WIP] CI tests: use ubuntu 24.04 for clang tidy and clang sanitizer tests
Oct 2, 2024
…4_04_for_clang_tidy_and_sanitizer_checks
…4_04_for_clang_tidy_and_sanitizer_checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I am updating the OS for the clang-tidy and clang sanitizer tests to Ubuntu 24.04, since it is no longer in beta for github hosted runners. The PR also bumps the version of
clang
used for sanitizer tests from 17 to 18.The sanitizer test was already using
ubuntu:23.10
via a container, so some changes consists in removing lines that were only necessary to run inside a container.For the clang-tidy test the final goal is also to bump the version of
clang-tidy
from 15 to 18, but this will be done in a separate PR (it will require to update the clang-tidy configuration file).