-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AnalyticFluxDistribution class #5422
Merged
RemiLehe
merged 17 commits into
ECP-WarpX:development
from
oshapoval:add_analytic_flux_distribution
Dec 12, 2024
Merged
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1d64d69
Added AnalyticFluxDistribution class
oshapoval 4f7f98a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0dc0f0b
Updated picmistandard to 0.32.0
oshapoval f8f2f0b
Merge branch 'add_analytic_flux_distribution' of https://github.com/o…
oshapoval 6be6402
Updated AnalyticFluxDistribution class: enabled the flux variable to …
oshapoval 0c5c764
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7905c27
Merge remote-tracking branch 'origin/development' into add_analytic_f…
oshapoval 3d1b6fd
Updated picmistandard to 0.33.0
oshapoval e2d9c22
Merge remote-tracking branch 'origin' into add_analytic_flux_distribu…
oshapoval 0de3e53
Merge remote-tracking branch 'origin/development' into add_analytic_f…
oshapoval f908030
Added inject_from_embedded_boundary option to AnalyticFluxDistributio…
oshapoval 335d64c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1d1e6c3
Refactored code to avoid duplication by creating parent and subclass …
oshapoval 4ccbb6d
Merge branch 'add_analytic_flux_distribution' of https://github.com/o…
oshapoval d594d71
Clean-up
oshapoval 4e0e5fc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b15246d
Because of the multiple inheritance, the init methods must be explici…
dpgrote File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a different way to handle this? This is an exact duplicate of
UniformFluxDistribution
except for the one keyword argumentflux_expression
.This could be simplified if the picmistandard class took the same argument,
flux
, as the uniform distribution, then one could do "UniformFluxDistribution = AnalyticFluxDistribution" and have only one version of the class.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
Note that we also have two different classes for the volume injection:
UniformDistribution
andAnalyticDistribution
, so we were trying to mirror the same setup here forUniformFluxDistribution
andAnalyticFluxDistribution
.Do you think that your comment also applies to
UniformDistribution
andAnalyticDistribution
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out, I will refactor accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UniformDistribution and AnalyticDistribution are quite a bit different from each other and it's probably too late to change that API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR ready? I still see the duplication of 'UniformFluxDistribution' - this is fine if that is the intent. Also,
UniformFluxDistribution
has theinject_from_embedded_boundary
option - would that also be supported with the analytic distribution?