Remove theta() function from ImplicitSolver base class. #5441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinRayAngus
added
cleaning
JustinRayAngus
force-pushed
the
implicit_mod
branch
3 times, most recently
from
d48ff80 to
d1439af
Compare
…t to ComputeRHS().
… the appropriate fractional time step. Removed theta() function from ImplicitSolver.H.
JustinRayAngus
force-pushed
the
implicit_mod
branch
from
d1439af to
72c56c2
Compare
dpgrote
reviewed
Nov 14, 2024
| @@ -83,12 +83,9 @@ public: | |||
| virtual void ComputeRHS ( WarpXSolverVec& a_RHS, | |||
There was a problem hiding this comment.
I notice that the comments do not have the list of input parameters for the routines. This is not for this PR, but can be added in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides some minor cleanup to the implicit solvers.
Added the simulation time step (potentially adaptive) as a member to the ImplicitSolver base class. This removes the need to circularly pass a_dt from the implicit solver to the nonlinear solver and back to functions in the implicit solver class (e.g., ComputeRHS()).
The time step passed to m_nlsolver->Solve() inside OneStep() from the Implicit solvers is now the appropriate fractional time step. This removes the need for the theta() function called by the preconditioner. The theta() function is removed from the ImplicitSolver base class.