Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build tests with -g1 compile option #5443

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Nov 5, 2024

Build and run CI tests with more debug information by adding the -g1 compile option.

@EZoni EZoni added the component: tests Tests and CI label Nov 5, 2024
@EZoni EZoni force-pushed the ci_relwithdebinfo branch from f46bf29 to 8d2b22e Compare November 5, 2024 23:05
@EZoni EZoni changed the title [WIP] CI: run tests in RelWithDebInfo mode [WIP] CI: build tests with -g compile option Nov 5, 2024
@EZoni EZoni force-pushed the ci_relwithdebinfo branch from 8d2b22e to 03ec749 Compare November 6, 2024 00:50
@EZoni EZoni force-pushed the ci_relwithdebinfo branch from beb69ae to a95cabc Compare November 6, 2024 21:18
@EZoni
Copy link
Member Author

EZoni commented Nov 6, 2024

I injected manual crashing and tested that the backtrace files display line numbers as expected. For example, see logs at https://dev.azure.com/ECP-WarpX/WarpX/_build/results?buildId=19698&view=results.

@EZoni EZoni changed the title [WIP] CI: build tests with -g compile option CI: build tests with -g compile option Nov 6, 2024
@EZoni EZoni requested a review from WeiqunZhang November 6, 2024 23:34
@EZoni
Copy link
Member Author

EZoni commented Nov 6, 2024

Note that #2979 attempted to do the same a couple of years ago, but ran into problems related to cache size.

We might be close to the limit here too (see screenshot), but let's see if we can go ahead as is for now.

Screenshot from 2024-11-06 15-41-20

@WeiqunZhang
Copy link
Member

We could use -g1.

@EZoni EZoni changed the title CI: build tests with -g compile option CI: build tests with -g1 compile option Nov 7, 2024
@EZoni
Copy link
Member Author

EZoni commented Nov 7, 2024

@WeiqunZhang

Thanks, using -g1 seems to have resolved the cache size issue and it should still print out file names and line numbers in backtrace files. I think this PR is ready to review/merge.

@EZoni EZoni self-assigned this Nov 7, 2024
@EZoni EZoni merged commit 3d68665 into ECP-WarpX:development Nov 7, 2024
37 checks passed
@EZoni EZoni deleted the ci_relwithdebinfo branch November 7, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tests Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants