Use AMReX FFT for IGF Solver #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the implementation using HeFFTe. A new runtime parameter ablastr.do_serial_fft is added. The default is false. If it's true, we use only one process to do FFT.
WeiqunZhang
force-pushed
the
amrex_fft
branch
from
bea3b9d to
9d71976
Compare
|
@RemiLehe I didn't notice your checksum commit and I force-pushed to fix clang-tidy warnings. Sorry. Can you redo it? |
|
Sounds good, done. |
aeriforme
approved these changes
Nov 14, 2024
WeiqunZhang
force-pushed
the
amrex_fft
branch
2 times, most recently
from
11039af to
2e71716
Compare
WeiqunZhang
force-pushed
the
amrex_fft
branch
from
2e71716 to
f9b3699
Compare
RemiLehe
reviewed
Nov 18, 2024
| dm_global_fft.define(std::move(pmap)); | ||
| amrex::ParmParse pp("ablastr"); | ||
| pp.queryAdd("nprocs_igf_fft", nprocs); | ||
| nprocs = std::max(1,std::min(nprocs, amrex::ParallelDescriptor::NProcs())); |
There was a problem hiding this comment.
As a follow-up PR: we could add an automated test for the case ablastr.nprocs_igf_fft = 1 and add it in the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the implementation using HeFFTe. A new runtime parameter ablastr.nprocs_igf_fft is added. This parameter controls the the number of processes used by parallel FFT in the IGF solver. By default, all processes will be used.