Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license to explicitly list LLNL #5461

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update license to explicitly list LLNL #5461

merged 1 commit into from
Nov 18, 2024

Conversation

dpgrote
Copy link
Member

@dpgrote dpgrote commented Nov 14, 2024

I noticed this oversight in the LICENSE.txt file. Is there some official way of fixing this or is this PR enough?

EZoni
EZoni approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@EZoni EZoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is enough, but I would ask @jlvay and @RemiLehe to double check if something else needs to be done.

@jlvay
Copy link
Member

jlvay commented Nov 18, 2024

Looks good to me.

jlvay
jlvay approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@jlvay jlvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@EZoni EZoni merged commit 55653b3 into ECP-WarpX:development Nov 18, 2024
37 checks passed
@dpgrote dpgrote deleted the update_license branch November 18, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EZoni EZoni EZoni approved these changes

@jlvay jlvay jlvay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgrote @jlvay @EZoni