Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Cajita -> Cabana::Grid #680

Merged
merged 14 commits into from
Sep 21, 2023
Merged

Rename Cajita -> Cabana::Grid #680

merged 14 commits into from
Sep 21, 2023

Conversation

streeve
Copy link
Member

@streeve streeve commented Aug 31, 2023 •
edited
Loading

Deprecate Cajita namespace and library. Also deprecate cabanacore->Core for consistency. Closes #659

To do:

  • Make sure everything has a deprecation tag
  • Rename files
  • grep for Cajita
  • Verify with external builds
  • Also update cabanacore->Core and deprecate
  • Pin issue linking here, showing how to update code, and showing how to disable warnings in user builds

Post-merge

  • Update wiki

@streeve streeve self-assigned this Aug 31, 2023
@streeve streeve force-pushed the deprecate_cajita branch 4 times, most recently from 266d95d to a160efa Compare September 1, 2023 20:26
@streeve
Copy link
Member Author

streeve commented Sep 6, 2023

Can someone try to build any downstream code with this branch? I'm still having issues with codes linking to Cabana::Cajita (even though it's aliased to the new Cabana::Grid) @junghans @lebuller @kwitaechong @abisner

@abisner
Copy link
Collaborator

abisner commented Sep 6, 2023 •
edited
Loading

The Cajita::isNode, Cajita::isCell, etc. type-checker deprecations are missing in the new Cabana_Grid_Types.hpp.

@abisner
Copy link
Collaborator

abisner commented Sep 6, 2023

Same with Cajita::P2G::is_scatter_view<T>.

@streeve streeve force-pushed the deprecate_cajita branch 4 times, most recently from e9f2017 to 4b4e6a2 Compare September 14, 2023 01:44
@streeve streeve force-pushed the deprecate_cajita branch 2 times, most recently from a924034 to 9ad2837 Compare September 14, 2023 21:05
@streeve streeve mentioned this pull request Sep 15, 2023
Closed
@streeve
Copy link
Member Author

streeve commented Sep 15, 2023

@junghans @dalg24, added the option to disable warnings in the last commit here, let me know if you have any other suggestions. @lebuller @kwitaechong @abisner can one of you also review?

junghans
junghans approved these changes Sep 15, 2023
View reviewed changes
cmake/CabanaConfig.cmakein Outdated Show resolved Hide resolved
@junghans junghans enabled auto-merge September 15, 2023 17:17
@kwitaechong
Copy link
Collaborator

@junghans @dalg24, added the option to disable warnings in the last commit here, let me know if you have any other suggestions. @lebuller @kwitaechong @abisner can one of you also review?

Updated Picasso with new Cabana::Grid passes all tests. Looks good!

@streeve streeve force-pushed the deprecate_cajita branch 2 times, most recently from 521370d to e48ede9 Compare September 21, 2023 14:47
@streeve streeve disabled auto-merge September 21, 2023 14:47
@streeve
Copy link
Member Author

streeve commented Sep 21, 2023

Ignoring HIP timeout

@streeve streeve merged commit 57e3263 into ECP-copa:master Sep 21, 2023
31 of 32 checks passed
@streeve streeve deleted the deprecate_cajita branch September 21, 2023 17:18
@dalg24 dalg24 mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwitaechong kwitaechong kwitaechong approved these changes

@junghans junghans junghans approved these changes

@dalg24 dalg24 Awaiting requested review from dalg24

@sslattery sslattery Awaiting requested review from sslattery

Assignees

@streeve streeve

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plan to replace Cajita with Cabana::Grid
4 participants
@streeve @abisner @kwitaechong @junghans