Create particles with existing particles #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streeve
requested changes
Sep 19, 2023
|
@kwitaechong I think this is working - can you test in Picasso? |
streeve
force-pushed
the
cajita_particieinit
branch
from
4b48a85 to
6c6009c
Compare
streeve
force-pushed
the
cajita_particieinit
branch
from
6c6009c to
251d124
Compare
streeve
changed the title
lebuller
approved these changes
Sep 20, 2023
|
retest this please. |
|
@kwitaechong can you build/test this manually with Cuda? |
each Cabana/Cajita ParticleList tests are passed on Cuda |
|
Cuda tests all passed; ignoring other timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates both core and cajita (some changes to cajita test to reduce test time)