Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set accurate CMake project version and allow SameMajorVersion downstream #708

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Set accurate CMake project version and allow SameMajorVersion downstream #708

merged 2 commits into from
Oct 26, 2023

Conversation

streeve
Copy link
Member

@streeve streeve commented Oct 20, 2023

No description provided.

@streeve streeve requested review from dalg24 and junghans October 20, 2023 18:30
@streeve streeve mentioned this pull request Oct 20, 2023
Closed
dalg24
dalg24 reviewed Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.6.0 does not seem right to me.
It does not convey that it is a development version, not the actual release.

dalg24
dalg24 reviewed Oct 20, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@streeve streeve changed the title Set accurate CMake project version Set accurate CMake project version and allow SameMajorVersion downstream Oct 23, 2023
@streeve
Copy link
Member Author

streeve commented Oct 24, 2023

retest this please.

2 similar comments
@streeve
Copy link
Member Author

streeve commented Oct 25, 2023

retest this please.

@streeve
Copy link
Member Author

streeve commented Oct 26, 2023

retest this please.

@streeve
Copy link
Member Author

streeve commented Oct 26, 2023

CI timeouts unrelated

@streeve streeve added bug Something isn't working blocked Blocked by another necessary change and removed blocked Blocked by another necessary change labels Oct 26, 2023
@streeve streeve merged commit 63dd047 into ECP-copa:master Oct 26, 2023
29 of 32 checks passed
@streeve streeve deleted the fixup_version branch October 26, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@junghans junghans Awaiting requested review from junghans

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@streeve @dalg24