Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds linked cell parallel capability #712

Merged
merged 21 commits into from
May 3, 2024
Merged

Conversation

lebuller
Copy link
Collaborator

@lebuller lebuller commented Nov 7, 2023

No description provided.

@streeve streeve mentioned this pull request Nov 7, 2023
4 tasks
@streeve streeve added the enhancement New feature or request label Nov 7, 2023
@streeve streeve requested review from streeve and sslattery November 7, 2023 15:25
core/src/Cabana_Parallel.hpp Outdated Show resolved Hide resolved
core/src/Cabana_LinkedCellList.hpp Show resolved Hide resolved
core/src/Cabana_LinkedCellList.hpp Outdated Show resolved Hide resolved
core/src/Cabana_LinkedCellList.hpp Outdated Show resolved Hide resolved
core/src/Cabana_LinkedCellList.hpp Outdated Show resolved Hide resolved
core/src/Cabana_Parallel.hpp Outdated Show resolved Hide resolved
core/unit_test/tstNeighborList.hpp Outdated Show resolved Hide resolved
core/src/Cabana_LinkedCellList.hpp Show resolved Hide resolved
core/src/Cabana_LinkedCellList.hpp Outdated Show resolved Hide resolved
@lebuller lebuller marked this pull request as ready for review November 10, 2023 19:34
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: Patch coverage is 95.74468% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 96.5%. Comparing base (dcaa181) to head (6525c20).
Report is 59 commits behind head on master.

❗ Current head 6525c20 differs from pull request most recent head 96a0bc1. Consider uploading reports for the commit 96a0bc1 to get more accurate results

Files Patch % Lines
core/src/Cabana_LinkedCellList.hpp 93.2% 5 Missing ⚠️
core/src/Cabana_Parallel.hpp 97.9% 2 Missing ⚠️
core/src/Cabana_NeighborList.hpp 83.3% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #712    +/-   ##
=======================================
  Coverage    96.4%   96.5%            
=======================================
  Files          90      92     +2     
  Lines       14498   14849   +351     
=======================================
+ Hits        13989   14332   +343     
- Misses        509     517     +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@streeve
Copy link
Member

streeve commented Nov 28, 2023

Initial performance check on Frontier (with Verlet results for comparison)
linkedcell
verlet

Note that the results marked neighbor here are NOT exposed to the user directly (could still be done with a linear Kokkos parallel loop and direct neighbor interface usage) and the results marked iterate use the new custom neighbor_parallel_for restricted to LinkedCellLists

@streeve
Copy link
Member

streeve commented Nov 28, 2023

CI timeouts unrelated (and manually tested on HIP)

Co-authored-by: lebuller <65980408+lebuller@users.noreply.github.com>
@streeve
Copy link
Member

streeve commented May 2, 2024

Final performance comparisons from Frontier - no significant changes from previous results
lcl_performance_frontier
verlet_performance_frontier

@streeve
Copy link
Member

streeve commented May 3, 2024

Test failures unrelated (docker, jenkins, coverage)

@streeve streeve merged commit 1b0e2ed into ECP-copa:master May 3, 2024
31 of 34 checks passed
@streeve streeve deleted the lcl_neighbor branch May 3, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants