Merge pull request #476 from ERC725Alliance/fix/isDataAuthentic

Fix isDataAuthentic (bis)
ERC725Alliance · Oct 23, 2024 · 45b429d · 45b429d
2 parents 8d03cf4 + 27da039
commit 45b429d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@erc725/erc725.js",
-  "version": "0.24.0",
+  "version": "0.27.2",
   "description": "Library to interact with ERC725 smart contracts",
   "main": "build/main/src/index.js",
   "typings": "build/main/src/index.d.ts",

diff --git a/src/lib/utils.ts b/src/lib/utils.ts
@@ -550,7 +550,7 @@ export function isDataAuthentic(
   options: Verification,
   capture?: string[],
 ): boolean {
-  if (!options || !options.method) {
+  if (!options?.method || options?.method === '0x00000000') {
     return true;
   }
 
@@ -613,7 +613,9 @@ export function patchIPFSUrlsIfApplicable(
   receivedData: URLDataWithHash,
   ipfsGateway: string,
 ): URLDataWithHash {
-  if (receivedData?.url?.indexOf('ipfs://') !== -1) {
+  // Only map URL if it's indeed an ipfs:// URL and ignore if it's a data:// URL with JSON
+  // possibly containing an IPFS URL inside of the JSON data.
+  if (receivedData?.url?.startsWith('ipfs://')) {
     return {
       ...receivedData,
       url: receivedData.url.replace('ipfs://', ipfsGateway),