Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix missing array square brackets for encodeData #290

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

CJ42
Copy link
Collaborator

@CJ42 CJ42 commented May 24, 2023

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

Fix example in library docs where the methode encodeData takes an object directly ❌ instead of an array of objects ✅

@Hugoo
Copy link
Contributor

Hugoo commented Jul 12, 2023

Good point, missing from: #174

Could you also update the docs here:

image

So it says only "Array of objects":

https://docs.lukso.tech/tools/erc725js/classes/ERC725#encodedata

Thanks

Copy link
Contributor

@Hugoo Hugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update line 282 of this file please?

image

@Hugoo Hugoo merged commit 99e202a into develop Jul 12, 2023
2 checks passed
@Hugoo Hugoo deleted the fix-docs-encodedata branch July 12, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants