chore: update web3 to v1.10.0 and prettier to v3 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hugoo
changed the title
Hugoo
changed the title
CJ42
approved these changes
Aug 1, 2023
| "web3-providers-http": "^1.8.0", | ||
| "web3-utils": "^1.8.2" | ||
| "web3-eth-abi": "^1.10.0", | ||
| "web3-providers-http": "^1.10.0", |
There was a problem hiding this comment.
Nice! There were some improvements in this release
https://github.com/web3/web3.js/releases/tag/v1.10.0
| @@ -430,7 +430,7 @@ export class ERC725 { | |||
| static encodePermissions(permissions: Permissions): string { | |||
| const result = Object.keys(permissions).reduce((previous, key) => { | |||
| return permissions[key] | |||
| ? previous + hexToNumber(LSP6_DEFAULT_PERMISSIONS[key]) | |||
| ? previous + Number(hexToNumber(LSP6_DEFAULT_PERMISSIONS[key])) | |||
There was a problem hiding this comment.
Why is this casting necessary? Doesn't the function hexToNumber convert to a Number already?
There was a problem hiding this comment.
The type has changed in v1.9.0 -> https://github.com/web3/web3.js/releases/tag/v1.9.0
utils.toNumber and utils.hexToNumber can now return the large unsafe numbers as BigInt, if true was passed to a new optional parameter called bigIntOnOverflow (web3/web3.js#5845)
We dont call it with true so it should not output a BigInt, but still the TS type thinks it is Number or string. This is to limit to Number only (which should be the truth)
CallumGrindle
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.