Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use web3-utils instead of bignumber.js #304

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

Hugoo
Copy link
Contributor

@Hugoo Hugoo commented Aug 3, 2023

Let's save 18.2kb as this feature is already included in web3-utils

image

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #304 (0349a7b) into develop (122efa9) will increase coverage by 0.82%.
Report is 59 commits behind head on develop.
The diff coverage is 89.59%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #304      +/-   ##
===========================================
+ Coverage    83.04%   83.86%   +0.82%     
===========================================
  Files           18       18              
  Lines          979     1122     +143     
  Branches       218      252      +34     
===========================================
+ Hits           813      941     +128     
- Misses          91       97       +6     
- Partials        75       84       +9     
Files Changed Coverage Δ
src/lib/getData.ts 89.79% <ø> (ø)
src/lib/provider-wrapper-utils.ts 88.88% <ø> (-0.59%) ⬇️
src/lib/decodeMappingKey.ts 84.21% <60.00%> (-5.54%) ⬇️
src/lib/utils.ts 83.12% <76.92%> (-0.77%) ⬇️
src/lib/decodeData.ts 81.81% <83.33%> (+0.91%) ⬆️
src/provider/providerWrapper.ts 81.25% <90.00%> (-1.65%) ⬇️
src/lib/encoder.ts 83.95% <91.66%> (+6.04%) ⬆️
src/constants/constants.ts 100.00% <100.00%> (ø)
src/constants/interfaces.ts 100.00% <100.00%> (ø)
src/index.ts 76.76% <100.00%> (-0.24%) ⬇️
... and 2 more

... and 4 files with indirect coverage changes

@Hugoo Hugoo merged commit 287f5dd into develop Aug 3, 2023
2 checks passed
@Hugoo Hugoo deleted the remove-bignumberjs branch August 3, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants