Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.18.0 #305

Merged
merged 43 commits into from
Aug 3, 2023
Merged

Release v0.18.0 #305

merged 43 commits into from
Aug 3, 2023

Conversation

Hugoo
Copy link
Contributor

@Hugoo Hugoo commented Aug 3, 2023

0.18.0 (2023-08-03)

⚠ BREAKING CHANGES

Features

  • add checkPermissions function (17d2258)
  • Add new feature "Decode Mapping Key" (8c1f1fc)

Bug Fixes

improvement

  • change ArrayLength value from uint256 to uint128 (#287) (c95ee8a)
  • new encoding for static value types (not arrays []) (#288) (f0b04da)

YamenMerhi and others added 30 commits March 16, 2023 22:12
feat: Add checkPermissions function
Removes [tough-cookie](https://github.com/salesforce/tough-cookie). It's no longer used after updating ancestor dependency [web3](https://github.com/ChainSafe/web3.js). These dependencies need to be updated together.


Removes `tough-cookie`

Updates `web3` from 1.8.0 to 4.0.2
- [Release notes](https://github.com/ChainSafe/web3.js/releases)
- [Changelog](https://github.com/web3/web3.js/blob/4.x/CHANGELOG.md)
- [Commits](web3/web3.js@v1.8.0...v4.0.2)

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
- dependency-name: web3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…xamples/tough-cookie-and-web3--removed

chore(deps): bump tough-cookie and web3 in /examples
refactor: change 0.7.0 interfaceId to 0.10.2
docs: fix missing array square brackets for encodeData
refactor!: change `CHANGEPERMISSION` to `EDITPERMISSION`
YamenMerhi and others added 11 commits July 14, 2023 17:12
refactor: support `getDataBatch` of 5.0.0 ERC725 release
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
* refactor: change ArrayLength value from uint256 to uint128

* refactor: fix decoding for array length as `uint128`

* refactor!: encode value for `Array` length as `uint128` (16 bytes long)

* test: fix mock schemas for tests

* refactor: deprecate `ArrayLength` valueContent + use `encodeValueType` to encode Array length

* test: update mock schemas for array length as left padded not abi-encoded

* refactor: Update encoding/decoding for `uint128`

* test: add more tests

* chore: add sugested changes

* refactor: update the encoding for `uint128`

* chore: add spaces between `it` blocks

* test: improve tests

---------

Co-authored-by: CJ42 <31145285+CJ42@users.noreply.github.com>
Co-authored-by: CJ42 <cavallerajean@gmail.com>
…ord-wrap-1.2.4

chore(deps-dev): bump word-wrap from 1.2.3 to 1.2.4
* refactor!: valueType without padding (no abi-encoding)

* test: update tests to not include any padding and not abi-encoded data

* chore: fix linter errors for equality checks

* test: re-add previously deleted test cases for encoding `bytes`

* test: add more tests for the new encoding types

* refactor: and extra conditional check for `address` in `MappingWithGrouping`
* chore: update web3 to 1.10.0

* chore: update prettier to v3
* fix: return numbers as `number` not `string` when decoding

* fix: throw error when literals in `valueContent` doesn't fit in `valueType`

* refactor: decodeData hex detection

---------

Co-authored-by: Hugo Masclet <hugo@lukso.io>
* docs: show examples in details toggle for readability

* docs: improve subheadings to display on sidebar
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #305 (23703e7) into main (2aa3930) will increase coverage by 0.45%.
Report is 22 commits behind head on main.
The diff coverage is 90.82%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   83.41%   83.86%   +0.45%     
==========================================
  Files          18       18              
  Lines        1061     1122      +61     
  Branches      234      252      +18     
==========================================
+ Hits          885      941      +56     
- Misses         96       97       +1     
- Partials       80       84       +4     
Files Changed Coverage Δ
src/lib/getData.ts 89.79% <ø> (ø)
src/lib/decodeMappingKey.ts 84.21% <50.00%> (-4.68%) ⬇️
src/lib/decodeData.ts 81.81% <77.77%> (-0.43%) ⬇️
src/lib/encoder.ts 83.95% <89.09%> (+1.25%) ⬆️
src/constants/constants.ts 100.00% <100.00%> (ø)
src/constants/interfaces.ts 100.00% <100.00%> (ø)
src/index.ts 76.76% <100.00%> (ø)
src/lib/detector.ts 96.00% <100.00%> (+8.50%) ⬆️
src/lib/utils.ts 83.12% <100.00%> (+0.21%) ⬆️
src/provider/providerWrapper.ts 81.25% <100.00%> (+0.98%) ⬆️
... and 1 more

@Hugoo Hugoo marked this pull request as draft August 3, 2023 10:30
@Hugoo
Copy link
Contributor Author

Hugoo commented Aug 3, 2023

On hold as it is missing docs for this PR: https://github.com/ERC725Alliance/erc725.js/pull/286/files + export on the main class

* refactor: expose checkPermissions function

* test: check if checkPermission is exposed

* docs: add example for `checkPermissions` function
@Hugoo Hugoo marked this pull request as ready for review August 3, 2023 11:58
Copy link
Collaborator

@CallumGrindle CallumGrindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

Copy link
Collaborator

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be commits and PRs reference that are very old, for features/fixes that have already been released.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Hugoo Hugoo merged commit b3027c6 into main Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants