fix: Remove hardcoded require statement inside of module (esm) code. #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeneaVranceanu
approved these changes
Sep 14, 2023
Hugoo
reviewed
Sep 21, 2023
Hugoo
approved these changes
Sep 21, 2023
|
Waiting for @skimaharvey answer in our chat before merging |
skimaharvey
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
There was a
in the code which is illegal in a esm module.
What is the current behaviour (you can also link to an open issue here)?
When using a true esm compiler like esbuild or bun the require function will no longer be defined
in the esm (module) context.
What is the new behaviour (if this is a feature change)?
It will work in cjs and esm
Other information:
https://app.clickup.com/t/2645698/DEV-8268