fix: incorrect value in schema for array length in ...Map
#310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
🐜 Bug Fix
What is the current behaviour (you can also link to an open issue here)?
The schemas for the
...Mapvalue in the tuple mentionbytes8. But this was changed touint128.See following PRs in LIP repos for reference:
bytes8->uint128in LSP5 and LSP10 Map lukso-network/LIPs#173LSP4CreatorsMaptuple frombytes8touint128lukso-network/LIPs#233What is the new behaviour (if this is a feature change)?
Correct the schemas with the right value type in the tuple.