Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add permission EXECUTE_RELAY_CALL + use Bitwise OR | to toggle ON permissions #316

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

CJ42
Copy link
Collaborator

@CJ42 CJ42 commented Oct 17, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Merging #316 (28a871d) into develop (4ab134b) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff            @@
##           develop     #316   +/-   ##
========================================
  Coverage    83.89%   83.89%           
========================================
  Files           18       18           
  Lines         1124     1124           
  Branches       252      252           
========================================
  Hits           943      943           
  Misses          97       97           
  Partials        84       84           
Files Coverage Δ
src/constants/constants.ts 100.00% <ø> (ø)
src/index.ts 77.22% <ø> (ø)
src/types/Method.ts 100.00% <ø> (ø)

Copy link
Collaborator

@CallumGrindle CallumGrindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the permission value for the encode/decode permissions function?

@CJ42 CJ42 changed the title feat: add permission EXECUTE_RELAY_CALL feat: add permission EXECUTE_RELAY_CALL + use Bitwise OR | to toggle ON permissions Oct 17, 2023
@CallumGrindle CallumGrindle merged commit f24425a into develop Oct 17, 2023
2 checks passed
@CallumGrindle CallumGrindle deleted the build/upgrade branch October 17, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants