-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to encode LSP2 Array length only #326
Conversation
b2c62fa
to
fcee836
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #326 +/- ##
===========================================
+ Coverage 83.71% 83.77% +0.05%
===========================================
Files 18 17 -1
Lines 1130 1128 -2
Branches 255 259 +4
===========================================
- Hits 946 945 -1
+ Misses 98 93 -5
- Partials 86 90 +4 ☔ View full report in Codecov by Sentry. |
fcee836
to
839c9d1
Compare
What is the status of this? WIP for a month now. Shall we close it? |
4557dea
to
910d1a0
Compare
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
feature (wip)
What is the current behaviour (you can also link to an open issue here)?
Currently it is only possible to encode a full array of valueType when the keyType is
Array
.What is the new behaviour (if this is a feature change)?
Allow to only encode the Array length only of
uint128
that is 16 bytes long, not a full array.Other information: