Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to encode LSP2 Array length only #326

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

CJ42
Copy link
Collaborator

@CJ42 CJ42 commented Oct 25, 2023

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

feature (wip)

What is the current behaviour (you can also link to an open issue here)?

Currently it is only possible to encode a full array of valueType when the keyType is Array.

What is the new behaviour (if this is a feature change)?

Allow to only encode the Array length only of uint128 that is 16 bytes long, not a full array.

Other information:

@CJ42 CJ42 force-pushed the feat/array-length-encoding branch from b2c62fa to fcee836 Compare October 25, 2023 07:34
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (9640d9f) 83.71% compared to head (d4f51fd) 83.77%.
Report is 19 commits behind head on develop.

Files Patch % Lines
src/lib/encoder.ts 75.00% 0 Missing and 5 partials ⚠️
src/lib/getDataFromExternalSources.ts 33.33% 0 Missing and 2 partials ⚠️
src/lib/utils.ts 84.61% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #326      +/-   ##
===========================================
+ Coverage    83.71%   83.77%   +0.05%     
===========================================
  Files           18       17       -1     
  Lines         1130     1128       -2     
  Branches       255      259       +4     
===========================================
- Hits           946      945       -1     
+ Misses          98       93       -5     
- Partials        86       90       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CJ42 CJ42 force-pushed the feat/array-length-encoding branch from fcee836 to 839c9d1 Compare October 25, 2023 07:35
@Hugoo
Copy link
Contributor

Hugoo commented Nov 23, 2023

What is the status of this?

WIP for a month now. Shall we close it?

@CJ42 CJ42 changed the title feat(wip): allow to encode LSP2 Array length only feat: allow to encode LSP2 Array length only Nov 24, 2023
@CJ42 CJ42 marked this pull request as ready for review November 24, 2023 13:06
src/lib/utils.test.ts Outdated Show resolved Hide resolved
@Hugoo Hugoo merged commit 3a6be55 into develop Nov 24, 2023
2 checks passed
@Hugoo Hugoo deleted the feat/array-length-encoding branch November 24, 2023 15:04
This was referenced May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants