Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/gas config #331

Closed
wants to merge 47 commits into from
Closed

Conversation

kalote
Copy link
Contributor

@kalote kalote commented Oct 31, 2023

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

New gas configuration in the optional params setting:

const config = {
  ipfsGateway: 'https://YOUR-IPFS-GATEWAY/ipfs/',
  gas: 20_000_000, // optional, default is 2_000_000
};

const erc725 = new ERC725(schemas, address, RPC_URL, config);

I also removed the gasPrice from the constants.ts file as it was unused.

What is the current behaviour (you can also link to an open issue here)?

Fix #328

What is the new behaviour (if this is a feature change)?

Other information:

frozeman and others added 30 commits January 5, 2022 11:10
…ase--branches--main--components--erc725.js

chore(main): release 0.19.0
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #331 (1b1ee16) into develop (122efa9) will increase coverage by 0.67%.
Report is 84 commits behind head on develop.
The diff coverage is 88.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #331      +/-   ##
===========================================
+ Coverage    83.04%   83.71%   +0.67%     
===========================================
  Files           18       18              
  Lines          979     1130     +151     
  Branches       218      255      +37     
===========================================
+ Hits           813      946     +133     
- Misses          91       98       +7     
- Partials        75       86      +11     
Files Coverage Δ
src/constants/constants.ts 100.00% <100.00%> (ø)
src/constants/interfaces.ts 100.00% <100.00%> (ø)
src/lib/detector.ts 96.00% <100.00%> (+8.50%) ⬆️
src/lib/getData.ts 89.79% <ø> (ø)
src/lib/provider-wrapper-utils.ts 89.47% <100.00%> (ø)
src/schemas/index.ts 100.00% <100.00%> (ø)
src/types/Method.ts 100.00% <100.00%> (ø)
src/lib/decodeMappingKey.ts 84.21% <60.00%> (-5.54%) ⬇️
src/provider/providerWrapper.ts 81.48% <90.47%> (-1.42%) ⬇️
src/index.ts 75.00% <72.72%> (-2.00%) ⬇️
... and 3 more

... and 4 files with indirect coverage changes

@CJ42
Copy link
Collaborator

CJ42 commented Oct 31, 2023

@kalote you need to checkout the branch from develop ✅ not main
Could you rebase your PR please?

The diffs are not showing properly as a result.

@kalote kalote closed this Oct 31, 2023
@richtera
Copy link
Collaborator

@kalote @CJ42 The ipfsGateway thing will be new with the new IPFS library. I create a token authorized proxy which is compatible with that library but @CallumGrindle had problems using it in nodejs, so it may currently only work in the browser. I am working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird forced gas limit on getData
7 participants