Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync main #334

Merged
merged 15 commits into from
Nov 2, 2023
Merged

Sync main #334

merged 15 commits into from
Nov 2, 2023

Conversation

CallumGrindle
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #334 (c5b3890) into main (e7ed169) will increase coverage by 0.28%.
Report is 109 commits behind head on main.
The diff coverage is 90.20%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   83.42%   83.71%   +0.28%     
==========================================
  Files          18       18              
  Lines        1062     1130      +68     
  Branches      234      255      +21     
==========================================
+ Hits          886      946      +60     
- Misses         96       98       +2     
- Partials       80       86       +6     
Files Coverage Δ
src/constants/constants.ts 100.00% <100.00%> (ø)
src/constants/interfaces.ts 100.00% <100.00%> (ø)
src/lib/detector.ts 96.00% <100.00%> (+8.50%) ⬆️
src/lib/getData.ts 89.79% <ø> (ø)
src/lib/getDataFromExternalSources.ts 63.33% <ø> (ø)
src/lib/provider-wrapper-utils.ts 89.47% <100.00%> (+0.58%) ⬆️
src/lib/utils.ts 83.12% <100.00%> (+0.21%) ⬆️
src/provider/providerWrapper.ts 81.48% <100.00%> (+1.21%) ⬆️
src/schemas/index.ts 100.00% <100.00%> (ø)
src/types/Method.ts 100.00% <100.00%> (ø)
... and 4 more

Copy link
Collaborator

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the interface IDs. Again...

@CallumGrindle CallumGrindle merged commit 3b688a9 into main Nov 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants