-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change to verification object #343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJ42
reviewed
Nov 6, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #343 +/- ##
===========================================
- Coverage 83.71% 83.36% -0.36%
===========================================
Files 18 18
Lines 1130 1136 +6
Branches 255 259 +4
===========================================
+ Hits 946 947 +1
- Misses 98 100 +2
- Partials 86 89 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for these changes @richtera 🙏
CJ42
approved these changes
Nov 7, 2023
CallumGrindle
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
Change from verificationData/Function or hash/hashFunction to verification object.
Fix chai assert and debug jests.
Repair getVerificationMethod (getVerificationFunction) that said it would match signature or name
but only matched on signature.
What is the current behaviour (you can also link to an open issue here)?
The current values were recently changed from hash/hashFunction to verificationData/verificationFunction
but we also want a source property. Therefore this changes it to an object containing
{ method, source?, data }?
What is the new behaviour (if this is a feature change)?
All jests pass so it should not introduce functionality changes other than the property values.
Other information:
https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-3-Profile-Metadata.md