Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change to verification object #343

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Conversation

richtera
Copy link
Collaborator

@richtera richtera commented Nov 6, 2023

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

Change from verificationData/Function or hash/hashFunction to verification object.
Fix chai assert and debug jests.
Repair getVerificationMethod (getVerificationFunction) that said it would match signature or name
but only matched on signature.

What is the current behaviour (you can also link to an open issue here)?

The current values were recently changed from hash/hashFunction to verificationData/verificationFunction
but we also want a source property. Therefore this changes it to an object containing
{ method, source?, data }?

What is the new behaviour (if this is a feature change)?

All jests pass so it should not introduce functionality changes other than the property values.

Other information:

https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-3-Profile-Metadata.md

examples/src/instantiation.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/constants/constants.ts Outdated Show resolved Hide resolved
src/index.test.ts Show resolved Hide resolved
src/index.test.ts Show resolved Hide resolved
src/lib/encoder.ts Show resolved Hide resolved
src/lib/encoder.ts Outdated Show resolved Hide resolved
src/types/encodeData/JSONURL.ts Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #343 (e7302e4) into develop (c3d84c1) will decrease coverage by 0.36%.
The diff coverage is 77.41%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #343      +/-   ##
===========================================
- Coverage    83.71%   83.36%   -0.36%     
===========================================
  Files           18       18              
  Lines         1130     1136       +6     
  Branches       255      259       +4     
===========================================
+ Hits           946      947       +1     
- Misses          98      100       +2     
- Partials        86       89       +3     
Files Coverage Δ
src/constants/constants.ts 100.00% <100.00%> (ø)
src/lib/getDataFromExternalSources.ts 61.29% <33.33%> (-2.05%) ⬇️
src/lib/utils.ts 82.09% <81.81%> (-1.03%) ⬇️
src/lib/encoder.ts 83.39% <76.92%> (-0.57%) ⬇️

src/lib/encoder.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@CallumGrindle CallumGrindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for these changes @richtera 🙏

@CallumGrindle CallumGrindle merged commit cb1a8c7 into develop Nov 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants