Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more schemas available to parse via getSchema #351

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

CJ42
Copy link
Collaborator

@CJ42 CJ42 commented Nov 9, 2023

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

Feature

What is the current behaviour (you can also link to an open issue here)?

The function getSchema function can only parse data keys defined up to LSP6, not all the schemas defined under the schemas/ folder.

What is the new behaviour (if this is a feature change)?

Make the schemas for LSP8, LSP9, LSP17, etc... available to parse in the getSchema function.

Other information:

@codecov-commenter
Copy link

Codecov Report

Merging #351 (83e81d5) into develop (9640d9f) will decrease coverage by 0.42%.
Report is 15 commits behind head on develop.
The diff coverage is 76.31%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #351      +/-   ##
===========================================
- Coverage    83.71%   83.30%   -0.42%     
===========================================
  Files           18       18              
  Lines         1130     1144      +14     
  Branches       255      262       +7     
===========================================
+ Hits           946      953       +7     
- Misses          98       99       +1     
- Partials        86       92       +6     
Files Coverage Δ
src/constants/constants.ts 100.00% <100.00%> (ø)
src/constants/interfaces.ts 100.00% <ø> (ø)
src/schemas/index.ts 100.00% <100.00%> (ø)
src/lib/getDataFromExternalSources.ts 61.29% <33.33%> (-2.05%) ⬇️
src/lib/utils.ts 82.09% <81.81%> (-1.03%) ⬇️
src/lib/encoder.ts 82.78% <64.28%> (-1.18%) ⬇️

@Hugoo Hugoo merged commit b882379 into develop Nov 23, 2023
2 checks passed
@Hugoo Hugoo deleted the feat/more-schema-parser branch November 23, 2023 15:10
This was referenced May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants