refactor: improve code for tuple checks #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #353 +/- ##
===========================================
- Coverage 83.71% 83.40% -0.32%
===========================================
Files 18 19 +1
Lines 1130 1139 +9
Branches 255 259 +4
===========================================
+ Hits 946 950 +4
Misses 98 98
- Partials 86 91 +5
|
CJ42
changed the title
valueType
CJ42
changed the title
valueTypevalueType
CJ42
force-pushed
the
refactor/clean-code
branch
3 times, most recently
from
3de6505
to
9a8137a
Compare
CJ42
force-pushed
the
refactor/clean-code
branch
from
9a8137a
to
dba141b
Compare
CJ42
changed the title
valueType
Hugoo
approved these changes
Nov 23, 2023
| if (regexMatch) { | ||
| bytesLengths.push(parseInt(regexMatch[1], 10)); | ||
| } | ||
| if (regexMatch) bytesLengths.push(parseInt(regexMatch[1], 10)); |
There was a problem hiding this comment.
personal preference - but i prefer with brackets, i think it is easier to read and see it is an if
|
|
||
| let valueTypeToDecode = valueType; | ||
| const extractTupleElements = (tupleContent: string): string[] => |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
Refactor
What is the current behaviour (you can also link to an open issue here)?
Current code base work fine, but not easy to understand the code behind the tuple logic.
What is the new behaviour (if this is a feature change)?
Improve the code for tuple checking by create internal methods to valid and extract tuple content.
Other information: