Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update links #354

Closed
wants to merge 1 commit into from
Closed

docs: update links #354

wants to merge 1 commit into from

Conversation

Hugoo
Copy link
Contributor

@Hugoo Hugoo commented Nov 10, 2023

Update outdated links.

Spotted in:
lukso-network/docs#703

@codecov-commenter
Copy link

Codecov Report

Merging #354 (e415077) into develop (9640d9f) will decrease coverage by 0.49%.
Report is 16 commits behind head on develop.
The diff coverage is 72.72%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #354      +/-   ##
===========================================
- Coverage    83.71%   83.23%   -0.49%     
===========================================
  Files           18       18              
  Lines         1130     1139       +9     
  Branches       255      262       +7     
===========================================
+ Hits           946      948       +2     
- Misses          98       99       +1     
- Partials        86       92       +6     
Files Coverage Δ
src/constants/constants.ts 100.00% <100.00%> (ø)
src/constants/interfaces.ts 100.00% <ø> (ø)
src/lib/getDataFromExternalSources.ts 61.29% <33.33%> (-2.05%) ⬇️
src/lib/utils.ts 82.09% <81.81%> (-1.03%) ⬇️
src/lib/encoder.ts 82.78% <64.28%> (-1.18%) ⬇️

Copy link
Collaborator

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table is removed in #317 and #352 as the function is deprecated, so I guess it will not be relevant anymore?

Otherwise if we keep it, suggesting to remove the table and link to the actual interface ID table in the contracts section: https://docs.lukso.tech/contracts/interface-ids

So that we have less duplicate.

image

@Hugoo
Copy link
Contributor Author

Hugoo commented Nov 23, 2023

Closing as it was removed in this PR as stated by Jean:

@Hugoo Hugoo closed this Nov 23, 2023
@Hugoo Hugoo deleted the update-docs-links branch November 23, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants