-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: simplify README, fix incorrect LSP3 reference and improve Getting Started section #431
Conversation
// Part of LSP3-UniversalProfile Schema | ||
// https://github.com/lukso-network/LIPs/blob/master/LSPs/LSP-3-UniversalProfile.md | ||
// Part of LSP3-Profile-Metadata Schema | ||
// https://github.com/lukso-network/LIPs/blob/master/LSPs/LSP-3-Profile-Metadata.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FMI: What s the difference btw LSP3Profile
and SupportedStandards:LSP3Profile
as a schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LSP3Profile
= contains the VerifiableURI
that links to the JSON file. It is the actual profile metadata
SupportedStandards:LSP3Profile
= it is just a data key to confirm that this contract supports the LSP3 Metadata standard, and contain a certain set of keys (only LSP3Profile
in this case).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! super clear
Easier to review can be by looking at the preview of the edited Markdown docs in the branch:
README.md
getting-started.md