docs: simplify README, fix incorrect LSP3 reference and improve Getting Started section #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtera
approved these changes
May 6, 2024
| // Part of LSP3-UniversalProfile Schema | ||
| // https://github.com/lukso-network/LIPs/blob/master/LSPs/LSP-3-UniversalProfile.md | ||
| // Part of LSP3-Profile-Metadata Schema | ||
| // https://github.com/lukso-network/LIPs/blob/master/LSPs/LSP-3-Profile-Metadata.md |
There was a problem hiding this comment.
FMI: What s the difference btw LSP3Profile and SupportedStandards:LSP3Profile as a schema?
There was a problem hiding this comment.
LSP3Profile = contains the VerifiableURI that links to the JSON file. It is the actual profile metadata
SupportedStandards:LSP3Profile = it is just a data key to confirm that this contract supports the LSP3 Metadata standard, and contain a certain set of keys (only LSP3Profile in this case).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easier to review can be by looking at the preview of the edited Markdown docs in the branch:
README.mdgetting-started.md