Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename successor to avoid shadowing #881

Closed
wants to merge 1 commit into from
Closed

Rename successor to avoid shadowing #881

wants to merge 1 commit into from

Conversation

senceryazici
Copy link
Contributor

Some of the constructors in message_router.h are using arguments named successor, resulting in following warning/error message:

etl/message_router.h:296:5: error: declaration of ‘successor’ shadows a member of ‘etl::message_producer’

This PR renames arguments to successor_ to prevent shadowing.

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@jwellbelove
Copy link
Contributor

Thanks for the PR, but this has already been addressed in commit 7751373 in response to issue #823

This change will be released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@senceryazici @jwellbelove