Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(deps): Support 1.19.3 #27

Closed
wants to merge 5 commits into from
Closed

[WIP] feat(deps): Support 1.19.3 #27

wants to merge 5 commits into from

Conversation

Norbiros
Copy link

I used #25 and fixed a few things, so it works on 1.19.3. I also added Polish translations.

@Felix14-v2
Copy link
Contributor

Did you manage to make it work? It seems that I was doing something wrong, and I am getting this error

ClassNotFoundException: io.github.ezforever.thatorthis.internal.ModInjector
    at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
    at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
    at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
    at io.github.ezforever.thatorthis.internal.Bootstrap.<clinit>(Bootstrap.java:22)
    at io.github.ezforever.thatorthis.PreloadInitializer.onInitializing(PreloadInitializer.java:34)
    at io.github.ezforever.thatorthis.PreloadAdapter.<clinit>(PreloadAdapter.java:16)
    at java.base/java.lang.Class.forName0(Native Method)
    at java.base/java.lang.Class.forName(Class.java:467)
    at net.fabricmc.loader.impl.FabricLoaderImpl.setupLanguageAdapters(FabricLoaderImpl.java:439)
    at net.fabricmc.loader.impl.FabricLoaderImpl.finishModLoading(FabricLoaderImpl.java:349)
    at net.fabricmc.loader.impl.FabricLoaderImpl.freeze(FabricLoaderImpl.java:112)
    at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:149)
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

@Norbiros
Copy link
Author

It worked for me... Are you using correct version? With correct dependencies? I don't think I changed something that could cause this error.

@Felix14-v2
Copy link
Contributor

Honestly, i've no idea... I'm new to this, so I just compiled your repository and it doesn't look like it worked. Maybe you can post your build here or make a release in your repo?

@Norbiros
Copy link
Author

Norbiros commented Jun 27, 2023

Strange... When I run it with gradle runClient it works, but If I compile it and run it in normal minecraft it doesn't work. I am trying to fix this error...

@Norbiros
Copy link
Author

@SettingDust maybe you have idea how we can fix this problem?

@SettingDust
Copy link
Contributor

SettingDust commented Jun 27, 2023

FabricMC/fabric-loader#682
As I mentioned, that's the reason of the PR is WIP.
The class loader isn't the one
In general, you can't make ThatOrThis works.
Mixin can't mixin the class that loaded. And FabricLoader should always load before the mixin(In my mind)
But in Quilt, there is api for this. You can try to develop this mod on Quilt and switch to Quilt that with fabric mod compatibility #26

@Norbiros Norbiros changed the title feat(deps): Support 1.19.3 [WIP] feat(deps): Support 1.19.3 Jun 27, 2023
@Norbiros
Copy link
Author

Okay. Thanks for help!

@Norbiros
Copy link
Author

@SettingDust created a new project which supports 1.19.2.

@Norbiros Norbiros closed this Jul 13, 2023
@SettingDust
Copy link
Contributor

@SettingDust created a new project which supports 1.19.2.

It's in review on modrinth

@SettingDust
Copy link
Contributor

It's in review on modrinth

@Norbiros @Felix14-v2 Listed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants