Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maniac Patch : Adding separate camera pan speeds from Maniac Patch #482

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

ToolMan2k
Copy link
Contributor

@ToolMan2k ToolMan2k commented Jul 14, 2024

Maniac Patch has a was for scrolling screen with pixel precision.

It uses two doubles, stored inside SavePartyLocation at 0x8D and 0x8E respectively.

Sister request for EasyRPG/Player#3245

@ToolMan2k ToolMan2k changed the title Adding separate camera pan speeds from Maniac Patch Maniac Patch : Adding separate camera pan speeds from Maniac Patch Jul 14, 2024
@fdelapena fdelapena requested a review from Ghabry July 16, 2024 04:32
@Ghabry Ghabry added this to the 0.8.1 milestone Sep 5, 2024
@Ghabry
Copy link
Member

Ghabry commented Sep 5, 2024

@ToolMan2k sorry for the slow review process. Could you please rebase the commit so that I can approve it?

Maniac Patch has a was for scrolling screen with pixel precision.

It uses two doubles, stored inside SavePartyLocation at 0x8D and 0x8E respectively.
@ToolMan2k
Copy link
Contributor Author

@ToolMan2k sorry for the slow review process. Could you please rebase the commit so that I can approve it?

Done!

@Ghabry
Copy link
Member

Ghabry commented Sep 12, 2024

Jenkins: Test this please

@Ghabry Ghabry merged commit 8614f63 into EasyRPG:master Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants