Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, just did this mostly for fun but it would be useful to have the colour transforms be perceptually monotonic.
The rationale here is that the Color lib is essentially used as a colour picker for colorscheme tweaking/creating, so the improvements described here, here and here are relevant.
What I did so far:
nightfox.util.oklab
moduleIssues:
I'll leave it up to you to say how much breakage you feel comfortable with allowing and how.
Let me know if this is interesting to you. I did this mostly for fun and users who are interested could totally just copy the oklab lib I ported and use it in their overrides so this is not even necessarily worth merging.
(also thanks for a great extensible plugin and codebase!)