jon/scene-navigation-types

[Jon-edge]

*Includes a small fix for an unreachable nullish operator operand in SweepPrivateKeyCompletionScene

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• [z] Yes
• No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1208326850244194

[swansontec]

I have some suggestions, but I'm approving this anyhow because it's such a massive improvement. If you can get the suggestions working in, say, 1h of work, then great. Otherwise, let's get this merged regardless.

[swansontec]

If we are going to do this, we should do it for real, so:

type SellTabParamList = Omit<BuyTabParamList, 'pluginListBuy' | 'pluginViewBuy'> & {
  pluginListSell: GuiPluginListParams | undefined
  pluginViewSell: PluginViewParams
}

And delete the pluginListSell and pluginViewSell from BuyTabParamList

[swansontec]

We are copy-pasting a lot of lines of code here. We could simplify these guys by leveraging the existing fakeSceneProps implementation, but hacking the types:

export function fakeRootSceneProps<Name extends keyof RootParamList>(name: Name, params: RootParamList[Name]): RootSceneProps<Name> {
  return fakeSceneProps(name, params as any) as any
}

export function fakeDrawerSceneProps<Name extends keyof DrawerParamList>(name: Name, params: DrawerParamList[Name]): DrawerSceneProps<Name> {
  return fakeSceneProps(name, params as any) as any
}

// ... and thus for the rest

[swansontec]

Oh, this breaking these up is a good idea! You could do:

export function PluginViewBuy(props: BuyTabSceneProps<'pluginViewBuy'>) {
  const {navigation, params} = props
  return <GuiPluginViewScene navigation={navigation as NavigationBase} params={params} />

export function PluginViewSell(props: SellTabSceneProps<'pluginViewSell'>) {
  const {navigation, params} = props
  return <GuiPluginViewScene navigation={navigation as NavigationBase} params={params} />

export function PluginView(props: EdgeAppSceneProps<'pluginView'>) {
  const {navigation, params} = props
  return <GuiPluginViewScene navigation={navigation as NavigationBase} params={params} />
}

And then GuiPluginViewScene can take {navigation: NavigationBase, params: PluginViewParams }. We can solve the NavigationBase thing in a future PR.

[Jon-edge]

Made a spinoff task to address the comments: https://app.asana.com/0/1200972350208303/1208644065408258/f