Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transaction details navigation from SwapSuccessScene #5335

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix transaction details navigation from SwapSuccessScene #5335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/scenes/SwapSuccessScene.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,15 @@ export const SwapSuccessScene = (props: Props) => {

const handleDone = useHandler(() => {
setShowButton(false)
// Reset swap navigation stack:
navigation.navigate('edgeTabs', { screen: 'swapTab', params: { screen: 'swapCreate' } })
})

const handleTransactionDetails = useHandler(() => {
navigation.replace('transactionDetails', { edgeTransaction, walletId, onDone: handleDone })
// Reset swap navigation stack:
navigation.navigate('edgeTabs', { screen: 'swapTab', params: { screen: 'swapCreate' } })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered something like this initially, but thought that this causes extra scene transition animations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not notice any extra animations.

// Navigate to transaction details:
navigation.navigate('transactionDetails', { edgeTransaction, walletId, onDone: handleDone })
})

useAsyncEffect(
Expand Down
Loading