Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement read_rtd_temperature method on client #42

Merged
merged 1 commit into from
Aug 31, 2023
Merged

implement read_rtd_temperature method on client #42

merged 1 commit into from
Aug 31, 2023

Conversation

iaj2
Copy link
Contributor

@iaj2 iaj2 commented Aug 31, 2023

@iaj2
Copy link
Contributor Author

iaj2 commented Aug 31, 2023 

Test Suites: 1 passed, 1 total
Tests:       56 passed, 56 total
Snapshots:   0 total
Time:        5.646 s, estimated 6 s
Ran all test suites matching /tests\/integration\/AdcService.test.ts/i.

naomiven
naomiven approved these changes Aug 31, 2023
View reviewed changes
Copy link

@naomiven naomiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@iaj2 iaj2 merged commit 9cb6fb6 into dev Aug 31, 2023
@josiah-tesfu josiah-tesfu deleted the read_rtd branch December 6, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naomiven naomiven naomiven approved these changes

@jarell-santella jarell-santella Awaiting requested review from jarell-santella

@sjpark608 sjpark608 Awaiting requested review from sjpark608

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iaj2 @naomiven