Merge pull request #20 from EdgePi-Cloud/dev-fix-adc-inputs

fix default empty inputs

.github/workflows/create-release-tag.yml

@@ -0,0 +1,30 @@
+# This workflow will create a new tag based on latest commit to branch
+
+name: Create Release Tag
+
+on:
+  push:
+    branches:
+      - main
+
+jobs:
+  build-and-publish:
+    name: Create Release Tag
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          token: ${{ secrets.ACTIONS_BOT_TOKEN }}
+      - name: Get Current Version
+        run: echo "current_version=$(cat package.json | jq -r '.version')" >> $GITHUB_ENV
+      - name: Create Release Tag
+        env:
+          commit_name: bot-edgepi
+          commit_email: bot@edgepi.com
+          username: bot-edgepi
+        run: |
+          git config user.name ${{ env.commit_name }}
+          git config user.email ${{ env.commit_email }}
+          git tag -a release/v${{ env.current_version }} -m "tag release version ${{ env.current_version }}"
+          git push origin release/v${{ env.current_version }}

.github/workflows/npm-publish.yml

@@ -3,6 +3,8 @@ on:
   push:
     branches:
       - main
+    tags:
+      - release/*  
 jobs:
   build:
     runs-on: ubuntu-latest
@@ -13,7 +15,14 @@ jobs:
         with:
           node-version: '16.x'
           registry-url: 'https://registry.npmjs.org'
-      - run: npm ci
-      - run: npm publish --access public
+
+      - name: Publish Package to npm
+        run: | 
+         npm ci
+         npm publish --access public
         env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }
+
+      - name: Release Package
+      uses: ncipollo/release-action@v1.12.0
+

.github/workflows/versioning.yml

@@ -30,7 +30,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v2
         with:
-          node-version: 14 # Adjust this to your desired Node.js version
+          node-version: 16 # Adjust this to your desired Node.js version
 
       - name: Set Git user information
         run: |

edgepi-adc.html

@@ -21,10 +21,8 @@
       return this.name || "adc";
     },
     oneditprepare: function () {
-      const configTransportSelect = document.getElementById(
-        "node-input-transport"
-      );
-      const tcpField = document.querySelector(".form-row.tcp");
+      const transportType = document.getElementById("node-input-transport");
+      const tcpTransportInputs = document.querySelector(".form-row.tcp");
       const read = document.getElementById("node-input-read");
       const adcNum = document.getElementById("node-input-adcNum");
       const adc1 = document.getElementById("adc-option-adc1");
@@ -35,8 +33,8 @@
       const diffField = document.querySelector(".form-row.diff");
 
       function updateEditor() {
-        tcpField.style.display =
-          configTransportSelect.value === "Network" ? "flex" : "none";
+        tcpTransportInputs.style.display =
+          transportType.value === "Network" ? "flex" : "none";
         channelField.style.display = read.value === "single" ? "flex" : "none";
         dataRateField.style.display = read.value === "single" ? "flex" : "none";
         diffField.style.display = read.value === "diff" ? "flex" : "none";
@@ -51,7 +49,7 @@
         }
       }
       updateEditor();
-      configTransportSelect.addEventListener("change", updateEditor);
+      transportType.addEventListener("change", updateEditor);
       read.addEventListener("change", updateEditor);
       adcNum.addEventListener("change", updateEditor);
     },
@@ -210,7 +208,11 @@ <h3>Details</h3>
   <h3>Properties</h3>
   <dl class="message-properties">
     <dt>RPC Server</dt>
-    <dd>The connection to your EdgePi's RPC Server.</dd>
+    <dd>
+      The connection to your EdgePi's RPC Server. Use <strong>Local</strong> if
+      node-red is running on EdgePi. Otherwise use the
+      <strong>Network</strong> option and enter EdgePi's IP address / Hostname.
+    </dd>
   </dl>
   <dl class="message-properties">
     <dt>Read</dt>

edgepi-adc.js

@@ -14,10 +14,11 @@ module.exports = async function (RED) {
         node.on("input", async function (msg, send, done) {
           node.status({ fill: "green", shape: "dot", text: "input received" });
           try {
-            read = msg.readType || read; //prioritize the inputs in the msg
+            read = msg.readType || read;
             adcNum = msg.adc || adcNum;
             inputSelection = msg.payload || inputSelection;
             dataRate = msg.dataRate || dataRate;
+
             if (read !== "rtd") {
               await adc.setRtd(false, adcNum - 1);
             }

package.json

@@ -30,6 +30,6 @@
         "node-red": "^3.1.3"
     },
     "dependencies": {
-        "@edgepi-cloud/edgepi-rpc": "^1.1.0"
+        "@edgepi-cloud/edgepi-rpc": "^1.1.1"
     }
 }