Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): bump action versions, python for macosx #83

Merged
merged 12 commits into from
Jun 13, 2024

Conversation

pfeerick
Copy link
Member

@pfeerick pfeerick commented Jun 7, 2024

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

  • codecov/codecov-action@v2
  • actions/upload-artifact@v3

The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "compiled-ubuntu-20.04", "compiled-windows-latest", "storybook-static".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

  • actions/upload-artifact@v3

Code Coverage has been needing a token for the last three months, so the failure is expected.

cloudflare/pages-action@v1 is still using NodeJS v16, and there has not been any updates to it. Given the lack of movement of cloudflare/pages-action#117, and PRs that fix this, it is probably worth moving to https://github.com/cloudflare/wrangler-action as this is being (more) actively maintained. DONE

I also updated the link preview step to edit the message in place, so there should only be one comment from in a PR. Because it edits rather than deletes and replaces comment, prior links can be access that way if needed.

@pfeerick pfeerick changed the title chore(ci): bump action versions chore(ci): bump action versions, python for macosx Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@028537a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage        ?   39.54%           
=======================================
  Files           ?      103           
  Lines           ?    12006           
  Branches        ?      645           
=======================================
  Hits            ?     4748           
  Misses          ?     7251           
  Partials        ?        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdgeTX EdgeTX deleted a comment from github-actions bot Jun 8, 2024
@EdgeTX EdgeTX deleted a comment from github-actions bot Jun 8, 2024
@EdgeTX EdgeTX deleted a comment from github-actions bot Jun 8, 2024
@EdgeTX EdgeTX deleted a comment from github-actions bot Jun 8, 2024
@EdgeTX EdgeTX deleted a comment from github-actions bot Jun 8, 2024
@EdgeTX EdgeTX deleted a comment from github-actions bot Jun 8, 2024
@EdgeTX EdgeTX deleted a comment from github-actions bot Jun 8, 2024
@EdgeTX EdgeTX deleted a comment from github-actions bot Jun 8, 2024
Copy link

github-actions bot commented Jun 8, 2024

EdgeTX Buddy has been automatically deployed to Cloudflare.
✅ Preview: https://5b5582bf.buddy-7a6.pages.dev
✅ Storybook: https://5b5582bf.buddy-7a6.pages.dev/storybook

@pfeerick pfeerick enabled auto-merge (squash) June 8, 2024 10:19
Copy link
Collaborator

@freshollie freshollie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Nice job!

@pfeerick pfeerick merged commit 21b749c into main Jun 13, 2024
17 checks passed
@pfeerick pfeerick deleted the pfeerick/update-actions branch June 13, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants