Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve flashing speed #88

Merged
merged 3 commits into from
Aug 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,8 @@ jobs:
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Fetch compiled source
uses: actions/download-artifact@v4
with:
Expand Down
8 changes: 5 additions & 3 deletions e2e/pages/firmware-wizard/firmware-selection.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,9 @@ test("Copy URL button copies a link to the selected firmware", async ({
test.skip(browserName !== "chromium");
await (await queries.findByLabelText("Firmware version")).press("Enter");
await page
.locator(".ant-select-item-option[title='EdgeTX \"Santa\" v2.6.0']")
.locator(
".ant-select-item-option[title='EdgeTX \"Flying Dutchman\" v2.8.5']"
)
.click();

const radioSelector = await queries.findByLabelText("Radio model");
Expand All @@ -181,9 +183,9 @@ test("Copy URL button copies a link to the selected firmware", async ({

if (isElectron) {
expect(copiedUrl).toBe(
"buddy.edgetx.org/#/flash?version=v2.6.0&target=x10"
"buddy.edgetx.org/#/flash?version=v2.8.5&target=x10"
);
} else {
expect(copiedUrl).toBe("localhost:8081/#/flash?version=v2.6.0&target=x10");
expect(copiedUrl).toBe("localhost:8081/#/flash?version=v2.8.5&target=x10");
}
});
9 changes: 6 additions & 3 deletions src/shared/dfu/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -635,9 +635,12 @@
(ignoreErrors || dfuStatus.state !== dfuCommands.dfuERROR)
) {
// eslint-disable-next-line no-await-in-loop
await asyncSleep(dfuStatus.pollTimeout);
// eslint-disable-next-line no-await-in-loop
dfuStatus = await this.getStatus();
await asyncSleep(0);
try {
// eslint-disable-next-line no-await-in-loop
dfuStatus = await this.getStatus();
// eslint-disable-next-line no-empty
} catch (error) {}

Check warning on line 643 in src/shared/dfu/index.ts

View check run for this annotation

Codecov / codecov/patch

src/shared/dfu/index.ts#L638-L643

Added lines #L638 - L643 were not covered by tests
}

return dfuStatus;
Expand Down
Loading