-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CRUD module and API endpoints #100
Conversation
and add `$new_title` as parameter to copy operation
to capture permission issues
and add some comments
to use the new endpoints `/data/copy` and `/data/delete`
This is unfinished work!
and copy over some common functions
rather than its own implementation
that gets sent by javascript
for copying and deleting files
as a simple chain of "copy" and a "delete"
especially add a button
and some reformatting, and addition of some HTML namespaces
so the look of the buttons stays the same as before
depending on login status
NB, we still need to check for published files when deleting and renaming. But this should already be suppressed in the main form, not in the modal.
and remove old "create-file"-XQuery
and align behaviour regarding login status
the endpoint "rename" is now available at /data/controller.xql" and functions have been moved to "modules/common.xql"
Questions:
|
Looks as if you're not logged in properly?
That should present you with a (new) modal where you can add a title and filename. Once you hit "copy" on that modal's submit button you are redirected to the list page again and your copy should show up. |
Another caveat: all endpoints (except "/data/read") only accept POST requests! |
|
At least the error handling seems to work ;) But I think I found the issue—it seems to be related to the login: checking "Remember me" is causing trouble. Once you uncheck it, it should work. We had that before (can't remember now) and it looks as if we should disable (or fix) this "Remember me" option. |
Yes, it does work with "Remember me" unchecked. Can confirm the CRUD actions are successful, but different behaviours in browsers:
|
as `common:set-mei-title#2`
to not repeat code
from the "common" module
that got erroneously inserted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the functionality and all buttons/options work like they're supposed to.
Only (separate) things:
- the "Remember me" option in the login procedure does not work properly
replace with Esc-event; CSS fixes will be included via #100
This started with the broken "copy" button (closes #92) and resulted in a major rewrite of some basic CRUD functions.
There is still a lot that can be improved, but I think it's already an improvement as it is.
Changes so far:
crud:read
,crud:copy
,crud:create
, andcrud:delete
filter_get.xsl
andfilter_put.xsl
#90). The old endpoints in "/data/controller.xql" for Orbeon have been retained so far.<button>
elements within a<form>
to facilitate consistent capturing of events, styling, etc.prompt
with more elaborate modal. The modal grabs all information from the original form on the main list page.