General client update #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,6 +78,8 @@ paths: | |||
| - $ref: '#/components/parameters/UpdatedAfter' | |||
| - $ref: '#/components/parameters/UpdatedBefore' | |||
| - $ref: '#/components/parameters/PerPage' | |||
| - $ref: '#/components/parameters/PageOffset' | |||
| - $ref: '#/components/parameters/PageCursor' | |||
There was a problem hiding this comment.
These allow for pagination of results.
There was a problem hiding this comment.
This has been updated.
There was a problem hiding this comment.
This has been updated.
There was a problem hiding this comment.
This has been updated.
MattFisher
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This changeset has three key areas of change:
Update generator to use Docker
The previous/existing generator script directly used the Java-based OpenAPI generator tool. To ease use, this change moves to a docker-based approach, using official docker images for the tool. This is intended to allow easy upgrade/change of tool version as required.
Update API spec
The API spec has been updated/tweaked as a result of further/deeper use, and to reflect changes in the API itself (e.g., field type changes).
Regenerate client
The client code/tests/documentation has been regenerated from the above spec via the above tooling.
Summary of changes
Note: I have flagged the key files that have been manually changed (as opposed to the very many files that have changed as a result of regeneration).