-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PubSub): unbounded replay #2940
Conversation
🦋 Changeset detectedLatest commit: 7cdbf81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4848bd0
to
c4079a1
Compare
c859b15
to
5c85042
Compare
c4079a1
to
2c7a5fd
Compare
5c85042
to
4e18c4b
Compare
2aa3eeb
to
62af9a6
Compare
f45852b
to
4fdcf95
Compare
5e4b224
to
7c2eedc
Compare
13bbc9c
to
1ad8ec6
Compare
I think if we were going to add a replay option, we would need to add it to every strategy. Also switch to object arguments: Pubsub.unbounded<string>({ replaySize: 16 }) |
1ad8ec6
to
99504d8
Compare
I'm not sure how I like the idea about object argument. What do you think about |
capacity and replay could be separate buffers, so you could have a higher replay buffer compared to the capacity. Or the capacity could be the ceiling. Also I think the replay doesn't need to be tracked per strategy, but rather on the PubSubImpl. The replay buffer can be independent of the subscriber-based logic. |
99504d8
to
25b360d
Compare
I don't see a way to implement it in the I think it is possible to reimplement the whole |
993d069
to
b1cacbf
Compare
3907cb1
to
7cdbf81
Compare
9f3e895
to
b51e2ae
Compare
f32fa39
to
6e1a8bc
Compare
Type
Description
Implementation of replay last N values feature for
PubSub.unbounded(replayBufferSize: N = 0)
.Can further be used to create shared
Stream
#2943.Related