Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Stream): raceAll implementation #3131

Merged
merged 9 commits into from
Jul 5, 2024

Conversation

dilame
Copy link
Contributor

@dilame dilame commented Jun 30, 2024

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

I implemented raceAll using high-level API, not sure if it's a correct way. I just don't understand the low-level API yet:)

@dilame dilame requested a review from mikearnaldi as a code owner June 30, 2024 12:54
Copy link

changeset-bot bot commented Jun 30, 2024

🦋 Changeset detected

Latest commit: 45c3fad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot changed the base branch from main to next-minor June 30, 2024 12:54
@dilame dilame force-pushed the stream-race-all-naive branch 2 times, most recently from aad4921 to 22bf18b Compare July 2, 2024 11:55
@dilame dilame changed the title feat(Stream): raceAll naive implementation feat(Stream): raceAll implementation Jul 2, 2024
@dilame
Copy link
Contributor Author

dilame commented Jul 2, 2024

Now it should be a correct way

@tim-smart tim-smart merged commit 2b4fb20 into Effect-TS:next-minor Jul 5, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Jul 5, 2024
github-actions bot pushed a commit that referenced this pull request Jul 5, 2024
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 5, 2024
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 5, 2024
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 5, 2024
Co-authored-by: Tim <hello@timsmart.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants