Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Logger.prettyLogger & Logger.pretty #3146

Open
wants to merge 9 commits into
base: next-minor
Choose a base branch
from
Open

add Logger.prettyLogger & Logger.pretty #3146

wants to merge 9 commits into from

Conversation

tim-smart
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b1fa2b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot changed the base branch from main to next-minor July 3, 2024 04:04
@tim-smart tim-smart changed the title add Logger.prettyLogger and make it the default add Logger.prettyLogger & Logger.pretty Jul 3, 2024
@tim-smart
Copy link
Member Author

/snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024 •
edited
Loading

Good news @tim-smart, your snapshot has been published!

pnpm add @effect/cli@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/cluster@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/cluster-browser@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/cluster-node@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/cluster-workflow@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add effect@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/experimental@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/opentelemetry@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/platform@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/platform-browser@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/platform-bun@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/platform-node@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/platform-node-shared@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/printer@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/printer-ansi@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/rpc@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/rpc-http@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/schema@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/sql@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/sql-d1@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/sql-drizzle@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/sql-mssql@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/sql-mysql2@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/sql-pg@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/sql-sqlite-bun@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/sql-sqlite-node@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/sql-sqlite-react-native@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/sql-sqlite-wasm@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/typeclass@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676
pnpm add @effect/vitest@0.0.0-snapshot-5fe45984d8022d8f8001e1057a5bacdd3e510676

You can review the build log here.

@github-actions github-actions bot force-pushed the pretty-logger branch 2 times, most recently from bce9f6a to 5860ff7 Compare July 4, 2024 17:04
@tim-smart
Copy link
Member Author

It would be really nice if this was more customizable

I think we should lean towards a consistent experience over customizability here. In saying that, I think date formatting is an OK option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikearnaldi mikearnaldi Awaiting requested review from mikearnaldi mikearnaldi is a code owner

Assignees
No one assigned
Labels
next-minor
Projects
PR Backlog
Status: Discussion Ongoing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tim-smart @jessekelly881