-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Stream): rename argument names of mergeLeft and mergeRight from self/that to left/right for clarity #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e85322 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b1cacbf
to
a052853
Compare
883b1cd
to
6676bee
Compare
a052853
to
dbe532e
Compare
6676bee
to
05b6480
Compare
dbe532e
to
1179383
Compare
05b6480
to
c73d77c
Compare
1179383
to
89f105c
Compare
c73d77c
to
869516f
Compare
89f105c
to
b304c5c
Compare
869516f
to
fd72e2a
Compare
b304c5c
to
dd4c6fe
Compare
fd72e2a
to
7cfef90
Compare
0a9b20b
to
ad86900
Compare
dd4c6fe
to
d6c4889
Compare
ad86900
to
4896b7c
Compare
d6c4889
to
af13d8c
Compare
4896b7c
to
1089afd
Compare
af13d8c
to
c730f99
Compare
1089afd
to
1e85322
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
…rom self/that to left/right for clarity (#3160)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
…rom self/that to left/right for clarity (#3160)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
…rom self/that to left/right for clarity (#3160)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
…rom self/that to left/right for clarity (#3160)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
…rom self/that to left/right for clarity (#3160)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
…rom self/that to left/right for clarity (#3160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
In the documentation for mergeLeft it is written
But the declaration contains
self
andthat
arg names, so i need to watch generics to understand what is "left" and what is "right", which is an extra mental overhead. I think it's more user friendly to name arguments according to documentation and function name:)If it will be merged, i will refactor the rest functions with left/right semantic.
Description
Related